[pve-devel] [PATCH cluster] datacenter.cfg: add ha setting with shutdown_policy as format string property

[Fabian Grünbichler]

On Wed, Dec 19, 2018 at 12:48:07PM +0100, Thomas Lamprecht wrote:
> On 12/19/18 12:42 PM, Fabian Grünbichler wrote:
> > mostly spelling/grammer/phrasing, see inline
> > 
> > On Wed, Dec 19, 2018 at 11:39:38AM +0100, Thomas Lamprecht wrote:
> >> +my $ha_format = {
> >> +    shutdown_policy => {
> >> +	type => 'string',
> >> +	enum => ['freeze', 'failover', 'default'],
> > 
> > s/default/auto/ ? seems more appropriate ;)
> 
> Hmm, not really IMO, could suggest that we do some auto migration of the services,
> which we really don't and do not want.. not too sure, default is less connoted and
> not wrong ;)

hm. it just seems weird to encode a 'default' as enum value, when we
have an explicit 'default' property. I was thinking about 'auto' because
it automatically decides the policy depending on whether we are in a
shutdown or reboot, but maybe that also only makes sense now and not if
we add more policies.

I think if/when we introduce automatic (live-)migration as policy, we
would most likely call this migrate or live-migrate?

maybe someone else has another idea for a good name..