[pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom or no file extension

Dietmar Maurer dietmar at proxmox.com
Wed Jun 10 09:24:31 CEST 2015


> >>Yes, but this way you always modify the user config (after an 
> >>read/modify/write). 
> >>I would prefer to not touch the config. 
> 
> ah ok, I totally miss that !

The current code also do it:

   if($res->{file} =~ m/\.(raw|cow|qcow|qcow2|qed|vmdk|cloop)$/){
	$res->{format} = $1;
    }

I guess I should remove that also.

Just detected that we have 

sub qemu_img_format { ... }

So I will try to use this in print_drive_full(). Hope that 'hots_device'
format is OK for iscsi?




More information about the pve-devel mailing list