[pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom or no file extension

[Alexandre DERUMIER]

>>Yes, but this way you always modify the user config (after an 
>>read/modify/write). 
>>I would prefer to not touch the config. 

ah ok, I totally miss that !


>>If you do not mind, I will try to move it to print_drive_full(). 

Sure, no problem.


----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 10 Juin 2015 08:07:57
Objet: Re: [pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom or no file extension

> >>Wouldn't it be better to do it inside print_drive_full? 
> 
> Well, 
> print_drive_full already take format option from @qemu_drive_options 

Yes, but this way you always modify the user config (after an 
read/modify/write). 
I would prefer to not touch the config. 

If you do not mind, I will try to move it to print_drive_full().