[pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom or no file extension

[Alexandre DERUMIER]

>> Hope that 'hots_device' format is OK for iscsi? 

I'm not sure we need anymore host_device for qemu-img.

https://lists.nongnu.org/archive/html/qemu-devel/2011-06/msg02790.html

"People shouldn't explicitly specify host_device any more. raw is doing the
Right Thing."


I don't have iscsi san currently to test it currently.



----- Mail original -----
De: "dietmar" <dietmar at proxmox.com>
À: "aderumier" <aderumier at odiso.com>
Cc: "pve-devel" <pve-devel at pve.proxmox.com>
Envoyé: Mercredi 10 Juin 2015 09:24:31
Objet: Re: [pve-devel] [PATCH] parse_drive : set default format=raw if !cdrom or no file extension

> >>Yes, but this way you always modify the user config (after an 
> >>read/modify/write). 
> >>I would prefer to not touch the config. 
> 
> ah ok, I totally miss that ! 

The current code also do it: 

if($res->{file} =~ m/\.(raw|cow|qcow|qcow2|qed|vmdk|cloop)$/){ 
$res->{format} = $1; 
} 

I guess I should remove that also. 

Just detected that we have 

sub qemu_img_format { ... } 

So I will try to use this in print_drive_full(). Hope that 'hots_device' 
format is OK for iscsi?