[pve-devel] [PATCH] update_vm rework

Dietmar Maurer dietmar at proxmox.com
Fri Jan 27 09:56:41 CET 2012


> >>>I guess we want to keep the locking code?
> 
> To be really honest,I dont't understand really good how the locking work, so
> please correct my code ;)


OK, fixed it.


> > >{file},$vmid);
> >> + PVE::QemuServer::change_config_nolock($vmid, {}, { $opt => 1 },
> 
> >>>>Why do we write the config file here - that should not be necessary,
> because we do that a few lines later?
> 
> because just after
> 
> die "error hotplug $opt - put disk in unused";

ok, got it.

- Dietmar


More information about the pve-devel mailing list