[pmg-devel] [PATCH pmg-gui 1/1] fix #3648: ldap config: do not send empty bindpw

Dominik Csapak d.csapak at proxmox.com
Wed Oct 27 17:02:29 CEST 2021


so that we can reuse the saved one and the admin does not have
to enter the password on each config change (similar to PVE).

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 js/LDAPConfig.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js
index 19ec702..d7e4263 100644
--- a/js/LDAPConfig.js
+++ b/js/LDAPConfig.js
@@ -28,6 +28,11 @@ Ext.define('PMG.LDAPInputPanel', {
 	values.disable = values.enable ? 0 : 1;
 	delete values.enable;
 
+	// do not send empty password
+	if (values.bindpw === '') {
+	    delete values.bindpw;
+	}
+
 	return values;
     },
 
@@ -103,6 +108,7 @@ Ext.define('PMG.LDAPInputPanel', {
 		xtype: 'textfield',
 		inputType: 'password',
 		allowBlank: true,
+		emptyText: gettext('Unchanged'),
 		name: 'bindpw',
 		fieldLabel: gettext('Password'),
 	    },
-- 
2.30.2





More information about the pmg-devel mailing list