[pve-devel] [PATCH proxmox-ve-rs 01/17] add proxmox-network-types crate

[Stefan Hanreich]

On 3/31/25 16:09, Thomas Lamprecht wrote:
> Am 28.03.25 um 18:12 schrieb Gabriel Goller:
>> This is a common crate that is gonna be reused between
>> proxmox-ve-config, proxmox-frr and proxmox-perl-rs. It holds different
>> networking primitives, such as Ipv4/Ipv6-Cidr, NET and e.g.
>> HelloInterval (openfabric attribute) types. The decision for creating
>> this crate is two-fold:
>>
>> - we didn't want to import Ipv4Cidr (& Co) from
>>   proxmox-ve-config/firewall
>> - having proxmox-frr rely on proxmox-ve-config would be weird and
>>   wouldn't make proxmox-frr a 'real' standalone FRR-types crate.
>>
>> By moving the Ipv4Cidr (& Co) types here, we also need to update the
>> proxmox-firewall crate.
> 
> I'm fine with a dedicated crate, but I'm wondering if either this is
> the wrong repo and it should live in the general proxmox workspace or
> if it should be named `proxmox-ve-network-types`.
> 
> Another alternative might be to split out the generic stuff – hostname
> and CIDR – to a generic crate – existing or new – in proxmox workspace
> and then create a proxmox-sdn-types one – probably also in the proxmox
> workspace for easier re-use in clients.
> Splitting the types that are quite SDN specific and those that are
> rather generic networking types might feel a bit more logical if one
> looks outside the SDN side of networking use cases.

Yes, the second approach sounds sensible imo, the OpenFabric / OSPF
types are quite specific...

Christoph also expressed interested in the network-types (for the
installer) so moving the general ones to a crate in proxmox is fine by
me and there are probably even more places where we could use them (PDM
SDN integration will probably sooner or later make use of them as well).

So we'll split it into two and include that in a v2!