[pve-devel] [PATCH proxmox-perl-rs 6/7] perl-rs: sdn: OSPF perlmod methods

Gabriel Goller g.goller at proxmox.com
Fri Mar 28 18:13:13 CET 2025


CRUD methods for perlmod that call the helper functions defined earlier.
Also add a method that returns the FRR daemons to be enabled and a
method that generates FRR configuration after validating it.

Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
Co-authored-by: Stefan Hanreich <s.hanreich at proxmox.com>
---
 pve-rs/src/sdn/ospf.rs | 165 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 165 insertions(+)

diff --git a/pve-rs/src/sdn/ospf.rs b/pve-rs/src/sdn/ospf.rs
index f6aac0db83f1..63ce0d53ffb8 100644
--- a/pve-rs/src/sdn/ospf.rs
+++ b/pve-rs/src/sdn/ospf.rs
@@ -205,4 +205,169 @@ mod export {
             OspfSectionConfig::write_section_config("sdn/fabrics/ospf.cfg", &guard)
         }
     }
+
+    #[export(raw_return)]
+    fn running_config(
+        #[raw] class: Value,
+        raw_config: HashMap<String, OspfSectionConfig>,
+    ) -> Result<perlmod::Value, anyhow::Error> {
+        // we cannot just construct it from the HashMap via From, since then the order is empty
+        let section_config = raw_config.into_iter().collect();
+
+        let return_value = PerlSectionConfig {
+            section_config: Mutex::new(section_config),
+        };
+
+        Ok(perlmod::instantiate_magic!(&class, MAGIC => Box::new(
+                return_value
+        )))
+    }
+
+    #[export(raw_return)]
+    fn config(#[raw] class: Value, raw_config: &[u8]) -> Result<perlmod::Value, anyhow::Error> {
+        let raw_config = std::str::from_utf8(raw_config)?;
+
+        let config = OspfSectionConfig::parse_section_config("ospf.cfg", raw_config)?;
+        let return_value = PerlSectionConfig {
+            section_config: Mutex::new(config),
+        };
+
+        Ok(perlmod::instantiate_magic!(&class, MAGIC => Box::new(
+                return_value
+        )))
+    }
+
+    /// Writes the config to a string and returns the configuration and the protocol.
+    #[export]
+    fn write(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+    ) -> Result<(String, String), Error> {
+        let full_new_config = this.write()?;
+
+        // We return the protocol here as well, so that in perl we can write to
+        // the correct config file
+        Ok((full_new_config, "ospf".to_string()))
+    }
+
+    #[export]
+    fn add_fabric(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        new_config: AddFabric,
+    ) -> Result<(), Error> {
+        this.add_fabric(new_config)?;
+
+        Ok(())
+    }
+
+    #[export]
+    fn add_node(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        new_config: AddNode,
+    ) -> Result<(), Error> {
+        this.add_node(new_config)
+    }
+
+    #[export]
+    fn edit_fabric(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        new_config: EditFabric,
+    ) -> Result<(), Error> {
+        this.edit_fabric(new_config)
+    }
+
+    #[export]
+    fn edit_node(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        new_config: EditNode,
+    ) -> Result<(), Error> {
+        this.edit_node(new_config)
+    }
+
+    #[export]
+    fn delete_fabric(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        delete_config: DeleteFabric,
+    ) -> Result<(), Error> {
+        this.delete_fabric(delete_config)?;
+
+        Ok(())
+    }
+
+    #[export]
+    fn delete_node(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        delete_config: DeleteNode,
+    ) -> Result<(), Error> {
+        this.delete_node(delete_config)?;
+
+        Ok(())
+    }
+
+    #[export]
+    fn get_inner(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+    ) -> HashMap<String, OspfSectionConfig> {
+        let guard = this.section_config.lock().unwrap();
+        guard.clone().into_iter().collect()
+    }
+
+    #[export]
+    fn get_fabric(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        fabric: Area,
+    ) -> Result<OspfSectionConfig, Error> {
+        let guard = this.section_config.lock().unwrap();
+        guard
+            .get(&fabric.to_string())
+            .cloned()
+            .ok_or(anyhow::anyhow!("fabric not found"))
+    }
+
+    #[export]
+    fn get_node(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        fabric: Area,
+        node: Hostname,
+    ) -> Result<OspfSectionConfig, Error> {
+        let guard = this.section_config.lock().unwrap();
+        let nodeid = NodeId::new(fabric, node).to_string();
+        guard
+            .get(&nodeid)
+            .cloned()
+            .ok_or(anyhow::anyhow!("node not found"))
+    }
+
+    #[export]
+    pub fn enabled_daemons(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        host_name: Hostname,
+    ) -> Vec<String> {
+        let config = this.section_config.lock().unwrap();
+
+        for (_, section) in config.iter() {
+            if let OspfSectionConfig::Node(node) = section {
+                if node.node_id.node == host_name {
+                    return vec!["ospfd".to_string()];
+                }
+            }
+        }
+
+        Vec::new()
+    }
+
+    #[export]
+    pub fn get_frr_raw_config(
+        #[try_from_ref] this: &PerlSectionConfig<OspfSectionConfig>,
+        node: Hostname,
+    ) -> Result<Vec<String>, Error> {
+        let config = this.section_config.lock().unwrap();
+        let ospf_config: Valid<OspfSectionConfig> = OspfSectionConfig::validate(config.clone())?;
+
+        let config = FabricConfig::with_ospf(ospf_config);
+        let frr_config = FrrConfigBuilder::default()
+            .add_fabrics(config)
+            .build(node)?;
+
+        to_raw_config(&frr_config)
+    }
 }
-- 
2.39.5





More information about the pve-devel mailing list