[pve-devel] [PATCH qemu v5 03/32] PVE backup: implement backup access setup and teardown API for external providers
Fiona Ebner
f.ebner at proxmox.com
Tue Mar 25 12:22:32 CET 2025
Am 25.03.25 um 12:11 schrieb Fiona Ebner:
> Am 24.03.25 um 14:02 schrieb Wolfgang Bumiller:
>> The code below can also be factored out as AFAICT it, too, is a copy, if
>> `backup_file` is a parameter (which which `NULL` may be passed, as
>> `g_strdup()` explicitly maps NULL to NULL), and `uuid` as well I guess
>> (here it's not touched but may as well be cleared (or the function would
>> ignore it when NULL is passed)).
>
> I now wonder if it's actually better to also generate a UUID for the
> backup access just like for the usual backup? It's returned as part of
> the result for query-backup and like that call sides could use the
> information (e.g. to see if it's still the same backup access) if ever
> required.
Although, it would require more nesting for the QAPI result. Not sure if
worth it.
More information about the pve-devel
mailing list