[pve-devel] [PATCH manager v3] ui: vm console: autodetect novnc or xtermjs

[Aaron Lauterer]

On  2025-03-24  17:57, Friedrich Weber wrote:
> On 25/02/2025 16:47, Aaron Lauterer wrote:
[…]
>> +
>> +	if (me.consoleType ==="kvm") {
> 
> nit: missing space after the ===

thanks for spotting this

> 
>> +	    Proxmox.Utils.API2Request({
>> +		url: `/api2/extjs/nodes/${me.nodename}/qemu/${me.vmid}/config`,
> 
> Stumbled upon this by accident: I guess this could should pass
> `current=1` to get the currently running config instead of the config
> with pending changes applied (because the running config one is the
> relevant one for deciding whether to use noVNC or xterm.js).

good point. I'll send another version that will request the current config