[pve-devel] [PATCH novnc 2/2] fix broken 'extra keys' images

Dominik Csapak d.csapak at proxmox.com
Mon Mar 24 16:03:37 CET 2025


this is currently broken upstream and it's unclear if this is the
correct fix, so add it seperately until upstream fixes it themselves.

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 .../patches/0020-fix-broken-extra-keys.patch  | 32 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 33 insertions(+)
 create mode 100644 debian/patches/0020-fix-broken-extra-keys.patch

diff --git a/debian/patches/0020-fix-broken-extra-keys.patch b/debian/patches/0020-fix-broken-extra-keys.patch
new file mode 100644
index 0000000..c072210
--- /dev/null
+++ b/debian/patches/0020-fix-broken-extra-keys.patch
@@ -0,0 +1,32 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Dominik Csapak <d.csapak at proxmox.com>
+Date: Mon, 24 Mar 2025 14:25:39 +0100
+Subject: [PATCH] fix broken extra keys
+
+commit:
+14f9ea5: ("Fix settings panel layout on small screens")
+
+changed the selector for the max-width calculation here to include the
+images type, but this was actually not intended.
+
+Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
+---
+ app/styles/base.css | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/app/styles/base.css b/app/styles/base.css
+index 6e9b25d..948074c 100644
+--- a/app/styles/base.css
++++ b/app/styles/base.css
+@@ -478,7 +478,7 @@ html {
+ .noVNC_panel button,
+ .noVNC_panel select,
+ .noVNC_panel textarea,
+-.noVNC_panel input:not([type=checkbox]):not([type=radio]) {
++.noVNC_panel input:not([type=checkbox]):not([type=radio]):not([type=image]) {
+     margin-left: 6px;
+     /* Prevent inputs in panels from being too wide */
+     max-width: calc(100% - 6px - var(--input-xpadding) * 2);
+-- 
+2.39.5
+
diff --git a/debian/patches/series b/debian/patches/series
index 212add7..66ee38e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -17,3 +17,4 @@
 0017-make-error-hideable.patch
 0018-show-start-button-on-not-running-vm-ct.patch
 0019-show-clipboard-button.patch
+0020-fix-broken-extra-keys.patch
-- 
2.39.5





More information about the pve-devel mailing list