[PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock

[Jing Luo]

On 2025-03-24 20:56, Thomas Lamprecht wrote:
> [...]
> Yeah, that I noticed later too, but it would be indeed good to check if
> this is a guarantee (i.e., by Debian policy) for all systems now, even
> if they got created with a very ancient PVE/Debian version.
> 
> I only did a quick check, and found [0]:
> 
>> Packages must not include files or directories under /run, or under
>> the older /var/run and /var/lock paths. The latter paths will normally
>> be symlinks or other redirections to /run for backwards compatibility.
> 
> [0]: 
> https://www.debian.org/doc/debian-policy/ch-opersys.html#run-and-run-lock
> 
> So does not seem like a hard guarantee that /var/lock is always a 
> symlink
> to /run/lock and that /var/run is always a symlink to /run, so if the
> careful approach would be to switch to the new paths for our Trixie 
> based
> builds and add a check for the case where /var/lock and /var/run are 
> not
> symlinks in the future pve8to9 checker script and output a 
> warning/error
> in that case; that said I'm not sure if it's worth it, would be maybe 
> good
> to see since which Debian/PVE version the symlink exists to be able to
> better judge that though.

I just found that this is technically a systemd thing: at boot time,
systemd creates the symlinks /var/run -> /run and /var/lock -> 
/run/lock, this
is written in /usr/lib/tmpfiles.d/var.conf and 
/usr/lib/tmpfiles.d/legacy.conf,
which has been true at least since Debian switched to systemd in 2015.

So these two have always been symlinks (unless the machine has not been 
restarted
in the past 10+ years).

[1] https://wiki.debian.org/ReleaseGoals/RunDirectory

-- 
Jing Luo
About me: https://jing.rocks/about/
GPG Fingerprint: 4E09 8D19 00AA 3F72 1899 2614 09B3 316E 13A1 1EFC
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: OpenPGP digital signature
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20250324/dc6f4fc5/attachment.sig>