[pve-devel] [PATCH pve-manager 2/2] move /run/vzdump.lock to /run/lock/vzdump.lock
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Mar 24 09:02:28 CET 2025
Am 22.03.25 um 16:17 schrieb Jing Luo:
> It's more appropriate under Debian, and vzdump.lock doesn't seem to
> be used by any other package.
This is very dangerous and needs a ton of work to be done right.
As any vzdump job that started before a package update got installed that
includes this (and the others) patches and any job started afterwards will
not be protected at all.
Same for all other patches and the respective things they use the lock
to protect against mutual access.
If this was done we would need to:
- keep the old lock path for one major release around and always acquire
the lock over the old path first for as long as we can safely say that
no old job is running. For a lot of things this means until the next
reboot, as /run is tmpfs backed and thus will be cleared then anyway.
- need some actual good reason instead of "it's more appropriate" which
can be a fine argument for adding new lock paths but definitively not
enough to justify moving existing ones.
The same holds for all patches of this series.
More information about the pve-devel
mailing list