[pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

Hannes Dürr h.duerr at proxmox.com
Wed Mar 19 10:21:13 CET 2025


In general the plugin implementation seems sensible, the only thing I 
didn't quite understand is the need for `get_status_ip`, more on that 
inline.

The series no longer applies to master, as there have been patches that 
add a fingerprint parameter to the API request [0].
For testing purposes I have already adapted the code and wanted to ask 
if it is okay for you if I continue the patchseries as co-author with my 
adjustments?
Of course you both remain registered as author.

[0] 
https://git.proxmox.com/?p=pve-network.git;a=commit;h=894d2d33e3b104bcdc8b83e3f205427db93800c3

On 3/6/25 12:08, lou.lecrivain at orange.fr wrote:
> From: Lou Lecrivain <lou.lecrivain at wdz.de>
>
> Following review from Hannes,
>
> I have made some improvements to the form of the code for the pve-network part.
> No functional changes.
>
> Related changes to pve-manager and pve-docs are also included the email thread.
>
> BR
>
> Lou Lecrivain (3):
>    ipam: nautobot: base plugin
>    ipam: nautobot: add testing for nautobot plugin
>    ipam: nautobot: add checks for prefix deletion
>
>   src/PVE/API2/Network/SDN/Ipams.pm             |   1 +
>   src/PVE/Network/SDN/Ipams.pm                  |   3 +
>   src/PVE/Network/SDN/Ipams/Makefile            |   2 +-
>   src/PVE/Network/SDN/Ipams/NautobotPlugin.pm   | 491 ++++++++++++++++++
>   src/test/ipams/nautobot/expected.add_ip       |  11 +
>   .../ipams/nautobot/expected.add_ip_notgateway |  11 +
>   .../ipams/nautobot/expected.add_next_freeip   |  11 +
>   src/test/ipams/nautobot/expected.add_subnet   |  11 +
>   src/test/ipams/nautobot/expected.del_ip       |  11 +
>   src/test/ipams/nautobot/expected.update_ip    |  11 +
>   src/test/ipams/nautobot/ipam_config           |  24 +
>   src/test/ipams/nautobot/sdn_config            |  20 +
>   src/test/ipams/netbox/ipam_config             |   8 +-
>   src/test/ipams/phpipam/ipam_config            |   8 +-
>   14 files changed, 620 insertions(+), 3 deletions(-)
>   create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
>   create mode 100644 src/test/ipams/nautobot/expected.add_ip
>   create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway
>   create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip
>   create mode 100644 src/test/ipams/nautobot/expected.add_subnet
>   create mode 100644 src/test/ipams/nautobot/expected.del_ip
>   create mode 100644 src/test/ipams/nautobot/expected.update_ip
>   create mode 100644 src/test/ipams/nautobot/ipam_config
>   create mode 100644 src/test/ipams/nautobot/sdn_config
>




More information about the pve-devel mailing list