[pve-devel] [RFC PATCH] ui: lxc: set nesting to false for privileged container during creation
Michael Köppl
m.koeppl at proxmox.com
Tue Mar 18 17:14:37 CET 2025
The current implementation is slightly misleading. When creating a
privileged container, the nesting checkbox is disabled but keeps its
current state. However, nesting is not enabled for privileged containers
even if the checkbox was set to true. Enabling nesting is still possible
through the Options menu.
Signed-off-by: Michael Köppl <m.koeppl at proxmox.com>
---
As an alternative to this, since we already discourage
the use of privileged containers [0], removing the checkbox for creating privileged
containers in the web UI might make sense. For the rare cases where they
are required, they can still be created using pct (although the question
remains whether privileged should be the default for pct create).
[0] https://forum.proxmox.com/threads/debian-12-lxc-template-systemd-failures.151630/post-686850
www/manager6/lxc/CreateWizard.js | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 62cda27a..c7ee56f7 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -7,6 +7,7 @@ Ext.define('PVE.lxc.CreateWizard', {
nodename: '',
storage: '',
unprivileged: true,
+ nestingEnabled: true,
},
formulas: {
cgroupMode: function(get) {
@@ -69,14 +70,22 @@ Ext.define('PVE.lxc.CreateWizard', {
value: '{unprivileged}',
},
fieldLabel: gettext('Unprivileged container'),
+ listeners: {
+ change: function(checkbox, value) {
+ var viewModel = checkbox.lookupViewModel();
+ if (!value && viewModel) {
+ viewModel.set('nestingEnabled', false);
+ }
+ },
+ },
},
{
xtype: 'proxmoxcheckbox',
name: 'features',
inputValue: 'nesting=1',
- value: true,
bind: {
disabled: '{!unprivileged}',
+ value: '{nestingEnabled}',
},
fieldLabel: gettext('Nesting'),
},
--
2.39.5
More information about the pve-devel
mailing list