[pve-devel] [PATCH pve_flutter_frontend] Fix #6231: Removed whitespace-trimming from password entry field
Laurențiu Leahu-Vlăducu
l.leahu-vladucu at proxmox.com
Thu Mar 13 09:19:13 CET 2025
I can confirm that logging in with passwords containing leading or
trailing whitespaces did not work previously, and your patch fixes the
issue.
However, please note that pve_flutter_frontend is the wrong repository,
as this patch is meant to be applied on the proxmox_login_manager
repository instead.
Other than that, please consider:
Reviewed-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu at proxmox.com>
Tested-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu at proxmox.com>
On 11.03.25 12:52, Alexander Abraham wrote:
> A user reported a bug where they were attempting to login into our
> app for PVE and they used a password with two spaces at the end.
> The login failed because of these trailing spaces. I removed the
> string trimming for the password entry field during login so users can
> use passwords that have spaces inside them.
>
> Signed-off-by: Alexander Abraham <a.abraham at proxmox.com>
> ---
> lib/proxmox_login_form.dart | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart
> index 735bd42..5916563 100644
> --- a/lib/proxmox_login_form.dart
> +++ b/lib/proxmox_login_form.dart
> @@ -464,7 +464,7 @@ class _ProxmoxLoginPageState extends State<ProxmoxLoginPage> {
> //cleaned form fields
> final origin = normalizeUrl(_originController.text.trim());
> final username = _usernameController.text.trim();
> - final String enteredPassword = _passwordController.text.trim();
> + final String enteredPassword = _passwordController.text;
> final String? savedPassword = widget.password;
>
> final password = ticket.isNotEmpty ? ticket : enteredPassword;
More information about the pve-devel
mailing list