[pve-devel] [PATCH qemu-server 6/8] machine: add S3/S4 power state properties

[Fiona Ebner]

Am 07.03.25 um 11:02 schrieb Dominik Csapak:
> On 3/6/25 15:52, Fiona Ebner wrote:
>> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
>>> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm
>>> index ebaf2dcc..377abc8a 100644
>>> --- a/PVE/QemuServer/Machine.pm
>>> +++ b/PVE/QemuServer/Machine.pm
>>> @@ -31,6 +31,16 @@ my $machine_fmt = {
>>>       enum => ['intel', 'virtio'],
>>>       optional => 1,
>>>       },
>>> +    'enable-s3' => {
>>> +    type => 'boolean',
>>> +    description => "Enables S3 power state. Defaults to true.",
>>> +    optional => 1,
>>> +    },
>>> +    'enable-s4' => {
>>> +    type => 'boolean',
>>> +    description => "Enables S4 power state. Defaults to true.",
>>> +    optional => 1,
>>> +    },
>>>   };
>>>     PVE::JSONSchema::register_format('pve-qemu-machine-fmt',
>>> $machine_fmt);
>>
>> Note that an UI patch is needed, because editing the machine there will
>> not preserve these values currently.
>>
> 
> alternative suggestions: I'd prefer to return the +pveX machines (where
> X > 0)
> also in the 'capabilities/qemu/machine' api call listing. This would
> 1. allow the users of the api to see that there are variants
> 2. allows the UI to work automagically (since it uses that api call)
>    - shows the correct version without losing info
>    - makes it possible to select e.g. a +pve1 variant
> 
> what do you say?

Sounds good. We should also add something to the docs to describe what
+pveN versions are. That would've been useful even before, but if we
expose it in the UI it's high time to do so.