[pve-devel] [PATCH-SERIES pve-network v3] Add Nautobot IPAM support

[Hannes Dürr]

I will review and test the series and then you can add it to the next 
version if necessary. Otherwise we can also edit it.

On 3/6/25 14:11, Lou.Lecrivain at wdz.de wrote:
> Re Hannes,
>
> You're welcome :)
>
> Sorry for the "from:", my mistake, must've slipped through before sending the patches.... (I may have forgot to signoff).
> Noted for the Co-developed-by.
>
> Would it be OK for you to edit that in or do I have to resend the patch series?
>
> MfG
> ________________________________________
> De : Hannes Dürr <h.duerr at proxmox.com>
> Envoyé : jeudi 6 mars 2025 13:13
> À : lou.lecrivain at orange.fr <lou.lecrivain at orange.fr>; pve-devel at lists.proxmox.com <pve-devel at lists.proxmox.com>
> Cc : jonatan.crystall at gwdg.de <jonatan.crystall at gwdg.de>; Lecrivain, Lou (WDZ) <Lou.Lecrivain at wdz.de>
> Objet : [!!ACHTUNG extern!!] - Re: [PATCH-SERIES pve-network v3] Add Nautobot IPAM support
>   
> Hi,
>
> and thanks to the both of you!
>
> Can you please resend the mail to our mailing list so that it is
> available for everyone please?
> Another tiny thing, we don't use "From: Lou Lecrivain
> <lou.lecrivain at wdz.de>" but "Signed-off-by: Lou Lecrivain
> <lou.lecrivain at wdz.de>"
> which indicates that contribution was created in whole or in part by
> yourself and you have the right to submit it under our open source license.
> jonathan crystall can use the "Co-developed-by: Jonatan Crystall
> <jonatan.crystall at gwdg.de>" to make it clear that he contributed the code.
>
> Best wishes,
> Hannes Dürr
>
> On 3/6/25 12:08, lou.lecrivain at orange.fr wrote:
>> From: Lou Lecrivain <lou.lecrivain at wdz.de>
>>
>> Following review from Hannes,
>>
>> I have made some improvements to the form of the code for the pve-network part.
>> No functional changes.
>>
>> Related changes to pve-manager and pve-docs are also included the email thread.
>>
>> BR
>>
>> Lou Lecrivain (3):
>>      ipam: nautobot: base plugin
>>      ipam: nautobot: add testing for nautobot plugin
>>      ipam: nautobot: add checks for prefix deletion
>>
>>     src/PVE/API2/Network/SDN/Ipams.pm             |   1 +
>>     src/PVE/Network/SDN/Ipams.pm                  |   3 +
>>     src/PVE/Network/SDN/Ipams/Makefile            |   2 +-
>>     src/PVE/Network/SDN/Ipams/NautobotPlugin.pm   | 491 ++++++++++++++++++
>>     src/test/ipams/nautobot/expected.add_ip       |  11 +
>>     .../ipams/nautobot/expected.add_ip_notgateway |  11 +
>>     .../ipams/nautobot/expected.add_next_freeip   |  11 +
>>     src/test/ipams/nautobot/expected.add_subnet   |  11 +
>>     src/test/ipams/nautobot/expected.del_ip       |  11 +
>>     src/test/ipams/nautobot/expected.update_ip    |  11 +
>>     src/test/ipams/nautobot/ipam_config           |  24 +
>>     src/test/ipams/nautobot/sdn_config            |  20 +
>>     src/test/ipams/netbox/ipam_config             |   8 +-
>>     src/test/ipams/phpipam/ipam_config            |   8 +-
>>     14 files changed, 620 insertions(+), 3 deletions(-)
>>     create mode 100644 src/PVE/Network/SDN/Ipams/NautobotPlugin.pm
>>     create mode 100644 src/test/ipams/nautobot/expected.add_ip
>>     create mode 100644 src/test/ipams/nautobot/expected.add_ip_notgateway
>>     create mode 100644 src/test/ipams/nautobot/expected.add_next_freeip
>>     create mode 100644 src/test/ipams/nautobot/expected.add_subnet
>>     create mode 100644 src/test/ipams/nautobot/expected.del_ip
>>     create mode 100644 src/test/ipams/nautobot/expected.update_ip
>>     create mode 100644 src/test/ipams/nautobot/ipam_config
>>     create mode 100644 src/test/ipams/nautobot/sdn_config
>>