[pve-devel] [PATCH manager v2 4/4] ui: window: add disk-format option to the restore window

Fiona Ebner f.ebner at proxmox.com
Wed Mar 5 13:49:59 CET 2025


"window:" by itself doesn't provide much information as a prefix. If you
use "restore window:" then you can drop that from the end of the commit
title.

Am 12.02.25 um 14:02 schrieb Markus Frank:
> @@ -141,9 +144,10 @@ Ext.define('PVE.window.Restore', {
>  			    view.lookupReference(`${key}Field`).setEmptyText(value);
>  			}
>  		    });
> -
> +		    let diskformat = view.down('pveDiskFormatSelector[name=diskformat]');
> +		    diskformat.setVisible(false);

I think it's better to do this in the component itself, see my comment
on the previous patch.

>  		    if (!allStoragesAvailable) {
> -			let storagesel = view.down('pveStorageSelector[name=storage]');
> +			let storagesel = view.down('pveStorageSelector[name=hdstorage]');
>  			storagesel.allowBlank = false;
>  			storagesel.setEmptyText('');
>  		    }

Looks good otherwise :)




More information about the pve-devel mailing list