[pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM

[Lou.Lecrivain at wdz.de]

De : Hannes Dürr <h.duerr at proxmox.com>
Envoyé : mercredi 19 février 2025 17:36
À : Proxmox VE development discussion <pve-devel at lists.proxmox.com>
Cc : Lecrivain, Lou (WDZ) <Lou.Lecrivain at wdz.de>
Objet : [!!ACHTUNG extern!!] - Re: [pve-devel] SPAM: [PATCH pve-network v2 0/7] add support for Nautobot IPAM
 
Sorry it took me so long to reply.

* Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.

* All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series


How did you test the patch, apart from the unit tests?

[0] https://pve.proxmox.com/wiki/Perl_Style_Guide

On 1/8/25 13:15, Lou Lecrivain via pve-devel wrote:
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re Hannes,

No problem. I myself wasn't really available either these last few weeks (sorry!)

> All 3 patches pve-network, pve-manager, pve-docs series can be
combined into one series
Thanks, will do. If I remember correctly, there was also some bug fixes related to these patches that I sent, right?
Do we agree that I keep them separated?

> How did you test the patch, apart from the unit tests?
We have a Nautobot instance in our lab (and in production). I deployed a PVE with zone type Simple, and proceeded
to test address reservation for the VMs from there. Also tested VM deletion, moving from one network to another and
all the rest of the use cases I could think of.

> Please check that you stick to our style guidelines [0], I noted a few
things inline but please check your patches again.
Will do too! Thanks for taking the time to review it.

BR