[pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 4 14:30:01 CET 2025


Am 04.03.25 um 14:14 schrieb Dominik Csapak:
>> While we're at it, should/can we make sorting numerically work too?
>> There is a 'numeric' option we could set, not sure if that's better or
>> not here and if that is intended to work for mixed strings like
>> soemthing9.yaml, something10.yaml or only for purely numeric ones.
>>
> good catch, from my short testing, yes this seems to work as intended, e.g.
> (copied & adapted from mdn):
> 
> console.log("foo2".localeCompare("foo10")); // 1
> console.log("foo2".localeCompare("foo10", undefined, { numeric: true })); // -1
> 
> i think using numeric sort here is more "natural",
> even many users already expect it to be sorted lexical i guess
> 
> any other opinions on that?

I agree with you and would enable that option too, as it's frontend only we
can always change this if doing so really causes some reasonable complaints.




More information about the pve-devel mailing list