[pve-devel] [PATCH storage 2/6] btrfs: fix volume size info for subvolumes in scalar context

[Fiona Ebner]

Am 03.03.25 um 10:03 schrieb Fiona Ebner:
> Am 03.03.25 um 08:31 schrieb Wolfgang Bumiller:
>> On Fri, Feb 28, 2025 at 03:50:18PM +0100, Fiona Ebner wrote:
>>> Return the same size as in list context. See also commit "plugin: file
>>> size info: be consistent about size of directory subvol".
>>>
>>> Fixes cloning containers with unsized subvolumes on BTRFS. Before the
>>> change, this would fail with "mkfs.ext4: Device size reported to be
>>> zero.".
>>
>> Interesting how it says "reported to be zero", when this commit changes
>> it from `1` to, well, zero?
> 
> When allocating the volume for the clone, we use the same size as the
> old volume. The value 0 will lead to using 'subvol' format for the new
> volume. With 1, it tries to use 'raw' format and then fails when
> attempting to format.

(to format the file system).

To be precise, we currently pass along 1/1024 as the size and 'raw'
format to the storage layer :P