[pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

[Thomas Lamprecht]

Am 10/10/2023 um 13:33 schrieb Christoph Heiss:
> On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
>> @@ -347,7 +347,7 @@ sub create_ipconf_view {
>>
>>      my $get_device_desc = sub {
>>  	my $iface = shift;
>> -	return "$iface->{name} - $iface->{mac} ($iface->{driver})";
>> +	return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}";
>
> I think it would be better to only show the state if the interface is
> actually UP - thus drawing immediate attention to these list entries and
> not completely overloading that dropdown.
> 
> Maybe even append it as "(UP)" instead of by dash (as it does not really
> identify the interface, but rather is a property of it).
> 

Or, if the GTK component and available fonts support it we could also use
unicode

UP   -> 🟢 https://unicode-explorer.com/c/1F7E2
DOWN -> ◯ (preferred, easier to differ for vision impaired people) or ⬤
        https://unicode-explorer.com/c/25EF or https://unicode-explorer.com/c/2B24

Would use less space and probably look better, if it works that is ^^