[pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

[Christoph Heiss]

On Tue, Oct 10, 2023 at 01:55:43PM +0200, Thomas Lamprecht wrote:
>
> Am 10/10/2023 um 13:33 schrieb Christoph Heiss:
> > On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
> >> @@ -347,7 +347,7 @@ sub create_ipconf_view {
> >>
> >>      my $get_device_desc = sub {
> >>  	my $iface = shift;
> >> -	return "$iface->{name} - $iface->{mac} ($iface->{driver})";
> >> +	return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}";
> >
> > I think it would be better to only show the state if the interface is
> > actually UP - thus drawing immediate attention to these list entries and
> > not completely overloading that dropdown.
> >
> > Maybe even append it as "(UP)" instead of by dash (as it does not really
> > identify the interface, but rather is a property of it).
> >
>
> Or, if the GTK component and available fonts support it we could also use
> unicode
I like the idea!

>
> UP   -> 🟢 https://unicode-explorer.com/c/1F7E2
A green circle would be problematic/non-optimal for people deuteranopia
(red-green color blindness). So maybe some other character/symbol
distinctly recognizable as "being connected, up" - but purely
color-coding things is not something that should be done IMO.

> DOWN -> ◯ (preferred, easier to differ for vision impaired people) or ⬤
>         https://unicode-explorer.com/c/25EF or https://unicode-explorer.com/c/2B24
Do we really need to explicitly mark non-UP interfaces? I'd think the
fact of it being not marked UP should provide enough context in this
situation.

>
> Would use less space and probably look better, if it works that is ^^