[pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox

[Christoph Heiss]

Needs to be done for the TUI installer as well. Easiest way here is to
add `state` to each interface in Proxmox::Sys::RunEnv::query_netdevs(),
then deserialize that in `setup::Interface`.

Looking at it, adding the MAC address there too would be great, if you
are already at it.

On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
>
> Signed-off-by: Filip Schauer <f.schauer at proxmox.com>
> ---
>  proxinstall | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxinstall b/proxinstall
> index d5b2565..9316578 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -347,7 +347,7 @@ sub create_ipconf_view {
>
>      my $get_device_desc = sub {
>  	my $iface = shift;
> -	return "$iface->{name} - $iface->{mac} ($iface->{driver})";
> +	return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}";
I think it would be better to only show the state if the interface is
actually UP - thus drawing immediate attention to these list entries and
not completely overloading that dropdown.

Maybe even append it as "(UP)" instead of by dash (as it does not really
identify the interface, but rather is a property of it).

>      };
>
>      my $run_env = Proxmox::Install::RunEnv::get();
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>