[pve-devel] [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention

Fiona Ebner f.ebner at proxmox.com
Wed Jun 21 17:02:00 CEST 2023


It just talks about the default behavior since PVE 7. It's rather
confusing to mention this, because the behavior doesn't change anymore
in PVE 8.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---

Intended for both master and stable-7.

 PVE/CLI/pve7to8.pm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 6b51e98e..87dc1dc3 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -608,8 +608,6 @@ sub check_backup_retention_settings {
 
     my $pass = 1;
 
-    my $node_has_retention;
-
     my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and will be removed in a " .
 	"future version, use 'prune-backups' instead.";
 
@@ -626,8 +624,6 @@ sub check_backup_retention_settings {
 	    $pass = 0;
 	    log_warn("$fn - $maxfiles_msg");
 	}
-
-	$node_has_retention = defined($param->{maxfiles}) || defined($param->{'prune-backups'});
     };
     if (my $err = $@) {
 	$pass = 0;
@@ -643,15 +639,6 @@ sub check_backup_retention_settings {
 	    $pass = 0;
 	    log_warn("storage '$storeid' - $maxfiles_msg");
 	}
-
-	next if !$scfg->{content}->{backup};
-	next if defined($scfg->{maxfiles}) || defined($scfg->{'prune-backups'});
-	next if $node_has_retention;
-
-	log_info(
-	    "storage '$storeid' - no backup retention settings defined - by default, since PVE 7.0"
-	    ." it will no longer keep only the last backup, but all backups"
-	);
     }
 
     eval {
-- 
2.39.2






More information about the pve-devel mailing list