[pve-devel] applied: [PATCH] tui: focus next button by default

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 22 14:54:32 CEST 2023

Am 21/06/2023 um 16:48 schrieb Dominik Csapak:
> except the password dialog, since the user must provide input
> to do that, we have to set the focus index on all relevant views
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> not sure if this is the correct approach, also the extra parameter feels
> slightly wrong, but didn't found a nicer way to do this
> any errors from focusing will be ignrored, but that shouldn't happen
> anyway until we add/remove buttons and the index changes
> alternatively we could create a second 'new_with_focus_next' (or
> 'without') that gets called respectively, but also seems a bit weird for
> that
>  proxmox-tui-installer/src/main.rs | 101 +++++++++++++++---------------
>  1 file changed, 52 insertions(+), 49 deletions(-)

seemingly forgot to write: I applied this one, but avoided setting the focus
on the install button for the summary step, as that can be a bit unexpected,
or even dangerous, thanks!

More information about the pve-devel mailing list