[pve-devel] [PATCH stable-7 manager 2/2] pve7to8: avoid confusing warning about required setting 'storage' for vzdump

Fiona Ebner f.ebner at proxmox.com
Wed Jun 21 17:02:01 CEST 2023

It's required in the schema for notes-template and protected, but when
parsing vzdump.conf, it shouldn't matter whether the storage parameter
is set or not.

The warning is ugly and users might interpret it as something that
needs to be acted upon for the upgrade:
parse error in '/etc/vzdump.conf' - 'storage': missing property - 'notes-template' requires this property\nmissing property - 'protected' requires this property

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>

Intended for both master and stable-7.

 PVE/CLI/pve7to8.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 87dc1dc3..2c288a2a 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -613,6 +613,8 @@ sub check_backup_retention_settings {
     eval {
 	my $confdesc = PVE::VZDump::Common::get_confdesc();
+	# vzdump.conf by itself doesn't need to honor any 'requires'
+	delete $confdesc->{$_}->{requires} for keys $confdesc->%*;
 	my $fn = "/etc/vzdump.conf";
 	my $raw = PVE::Tools::file_get_contents($fn);

More information about the pve-devel mailing list