[pve-devel] [PATCH storage v3 1/4] fix #3972: Remove the .notes file when a backup is deleted

Thomas Lamprecht t.lamprecht at proxmox.com
Wed May 25 17:06:10 CEST 2022


On 20/05/2022 15:28, Daniel Tschlatscher wrote:
> When a VM or Container backup was deleted, the .notes file was not
> removed, therefore, over time the dump folder would get polluted with
> notes for backups that no longer existed. As backup names contain a
> timestamp and as the notes cannot be reused because of this, I think
> it is safe to just delete them just like we do with the .log file.
> 
> Furthermore, I sourced the deletion of the log and notes file into a
> new function called "archive_auxiliaries_remove". Additionally, the
> archive_info object now returns one more field containing the name of
> the notes file. The test cases have to be adapted to expect this new
> value as the package will not compile otherwise.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>
> ---

the "changes since v2" sections are missing from all patches, making it
harder to check if all comments got addressed or what other changes there
were...

>  PVE/API2/Storage/Content.pm |  5 ++---
>  PVE/Storage.pm              | 20 +++++++++++++++-----
>  test/archive_info_test.pm   |  6 ++++++
>  3 files changed, 23 insertions(+), 8 deletions(-)
> 





More information about the pve-devel mailing list