[pve-devel] applied: [PATCH manager v2] fix #3994: Options menu entry in the System menu

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 13 10:00:37 CEST 2022


Am 5/13/22 um 09:55 schrieb Daniel Tschlatscher:
> On 5/12/22 17:13, Thomas Lamprecht wrote:
>> Some other points to improve:
>>
>> - setting the online help, maybe to 'proxmox_node_management' which would make
>>    it point to:
>>    https://pve.proxmox.com/pve-docs/chapter-sysadmin.html#proxmox_node_management
>>    (the chapter could maybe do good with some addition w.r.t. first start delay
> 
> This sounds to me like a suggestion to set the online help for the panel, i.e. the
> button in the top right corner. But that's already included in the patch.
> Or are you suggesting to put it somewhere else too?

None of the edit windows have it set. the top right corner is somewhat nice
sometimes but the real useful one is the one from the edit window, which is
much more visible, and especially the only one available if the window is open
as the background is masked then, having to close the window with some values
already half entered is the worst.

> 
>>
>> - It's not clear what unit the start delay has, you could mention that explicitly,
>>    simplest way to do so is adding a ' (s)' to the fieldLabel after the gettext.
> 
> The field does not display a value while displaying Default, though it explicitly states
> 'Seconds' after any value is set. I think it would become very clear to anybody then

That's too late, I need to know what I'm entering *on entering* not sometimes
later, when I already set a possible bogus value; while it hasn't that big
of an affect in this specific case it should be the general approach to UX
that the user knows what they enter, otherwise a UI is close to useless.

> what unit this setting represents.
> Still, adding ' (s)' probably wouldn't kill me either. 😉

Note that the "Default" in the grid is also wrong for unset, it should state "None".




More information about the pve-devel mailing list