[pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default

Fabian Ebner f.ebner at proxmox.com
Tue May 10 09:26:53 CEST 2022


Am 28.04.22 um 10:44 schrieb Matthias Heiserer:
> And move it from the advanced section to the always shown area.
> 
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
> 
> Especially in benchmarks, iothreads significantly improve IO performance.
> 

It's checked in the creation wizard, but (at least for me) not when
adding a new disk afterwards, which is unexpected.

Can we figure out the controller type here (maybe by passing along from
the parent component)? Then we could auto-select depending on the
controller type and maybe even display a quick note if there's mismatch.
As currently, people selecting an incompatible controller type will
still get the checkbox ticked automatically.




More information about the pve-devel mailing list