[pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default

[Daniel Tschlatscher]

I applied this patch in a few virtualized Proxmox instances. Existing
VM disk and controller settings were correctly applied, adding new
disks worked as expected.
I tried to find some settings combinations in the Editor panel that
would be wrong or nonsensical. Though, I couldn't find any problems
in this regard either.

I also ran a few (rather straightforward) benchmarks using fio and dd.
While fio write commands were only slightly faster, read benchmarks
were nearly twice as fast.
Writing with dd using IOThreads yielded a speed increase of about 50%
compared to a disk not using an IO thread.


Everything worked as advertised.

Tested-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>


On 4/28/22 10:44, Matthias Heiserer wrote:
> And move it from the advanced section to the always shown area.
>
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
>
> Especially in benchmarks, iothreads significantly improve IO performance.
>
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
>
> Changes from v1:
> set true by default instead of binding it
>
>   www/manager6/qemu/HDEdit.js | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
> index c643ee73..b9c5cc5c 100644
> --- a/www/manager6/qemu/HDEdit.js
> +++ b/www/manager6/qemu/HDEdit.js
> @@ -251,6 +251,16 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   		reference: 'discard',
>   		name: 'discard',
>   	    },
> +	    {
> +		xtype: 'proxmoxcheckbox',
> +		name: 'iothread',
> +		fieldLabel: 'IO thread',
> +		clearOnDisable: true,
> +		bind: {
> +		    disabled: '{!isVirtIO && !isSCSI}',
> +		},
> +		value: true,
> +	    },
>   	);
>   
>   	advancedColumn1.push(
> @@ -263,15 +273,6 @@ Ext.define('PVE.qemu.HDInputPanel', {
>   		    disabled: '{isVirtIO}',
>   		},
>   	    },
> -	    {
> -		xtype: 'proxmoxcheckbox',
> -		name: 'iothread',
> -		fieldLabel: 'IO thread',
> -		clearOnDisable: true,
> -		bind: {
> -		    disabled: '{!isVirtIO && !isSCSI}',
> -		},
> -	    },
>   	    {
>   		xtype: 'proxmoxcheckbox',
>   		name: 'readOnly', // `ro` in the config, we map in get/set values