[pve-devel] [PATCH manager] vzdump: generate notes: initialize potentially undef values
Fabian Ebner
f.ebner at proxmox.com
Fri May 6 12:59:38 CEST 2022
For VMs, $task->{hostname} might be undef and when running on a
stand-alone node, there is no cluster name.
Reported-by: Marco Gabriel <mgabriel at inett.de>
Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
PVE/VZDump.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index edcab696..8f11c820 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -74,8 +74,8 @@ my $generate_notes = sub {
my ($notes_template, $task) = @_;
my $info = {
- cluster => PVE::Cluster::get_clinfo()->{cluster}->{name},
- guestname => $task->{hostname},
+ cluster => PVE::Cluster::get_clinfo()->{cluster}->{name} // '',
+ guestname => $task->{hostname} // "VM $task->{vmid}", # is always set for CTs
node => PVE::INotify::nodename(),
vmid => $task->{vmid},
};
--
2.30.2
More information about the pve-devel
mailing list