[pve-devel] [PATCH futter_frontend 1/2] fix android splash screen logo

[Aaron Lauterer]

On 12/20/21 20:37, Thomas Lamprecht wrote:
> On 20/12/2021 16:38, Aaron Lauterer wrote:
>> The new splash screen that came with Android 12 has stricter rules
>> regarding the size and form of the logo in the splash screen [0].
> 
> oh, do you have an actual reference to the strict rules you found, as [0]
> 
> As I read [0] quite closely and basically all mentions regarding the
> drawable are IMO the opposite of strict, e.g.:
> 
>> The app icon (1) should be a vector drawable, and it can be static or animated.
> 
> And all other references are similarly vague and imply multiple times that
> any drawable should work.

I think the following line below figure 2 is the important one:
	"As with adaptive icons, one-third of the foreground is masked (3)."

Hinting at the #3 in the figure, which is the area outside the circle. Taking a closer look at the current splash screen, one will see that the drawable is masked in a circular shape. Depending on how it is scaling, the circular mask will be easier or harder to spot.

> 
>>
>> We do need to have a drawable that is a square with the logo / icon in
>> the center. That means the current approach with the png image resulted
>> in it being scaled to the full width and the circular mask cut if off.
> 
> hmm, the bitmap used sets `android:gravity` to `center` though, which is
> documented as:
> 
>> Place the object in the center of its container in both the vertical and
>> horizontal axis, not changing its size.
> 
> -- https://developer.android.com/guide/topics/resources/drawable-resource#XmlBitmap

That probably explains why it did look quite different on your phone than on mine regarding how large and cutoff it appeared, depending on how they are set up regarding the px to dp (device independent pixel) conversion.

> 
>> The result was a broken looking splash screen.
> 
> FWIW, I only run into the following issue:
> https://issuetracker.google.com/issues/207095799#comment10
> 
>>
>> I opted for the stacked variant of the logo and saved it as a vector
>> drawable in the xml format that android wants.
>>
>> [0] https://developer.android.com/guide/topics/ui/splash-screen
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>>   .../main/res/drawable/proxmox_splash_logo.xml | 69 +++++++++++++++++++
>>   .../app/src/main/res/values-night/styles.xml  |  2 +-
>>   android/app/src/main/res/values/styles.xml    |  2 +-
>>   3 files changed, 71 insertions(+), 2 deletions(-)
>>   create mode 100644 android/app/src/main/res/drawable/proxmox_splash_logo.xml
>>
>