[pve-devel] applied: Re: [RFC PATCH manager] ui: ACMEAccountCreate: improve layout of account dialog

Thomas Lamprecht t.lamprecht at proxmox.com
Thu May 14 16:31:10 CEST 2020


On 5/14/20 2:26 PM, Dominik Csapak wrote:
> by increasing the space for the link, and using a boxLabel instead
> of fieldLabel, which has better spacing for longer text
> 
> also move the e-mail before the directory to have all textboxes together
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> not really sure if it looks good now, but the current layout
> is rather ugly, so sending it as rfc
>  www/manager6/node/ACME.js | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 
>

applied, thanks! Made two not direct related followups after trying this:
* s/Name/Account Name/ as label, as else some people could think they need
  to put in their own name in there (E-Mail field is below, and that combi
  is a common pattern)

* hide TOS checkbox during load and reuse field references instead of doing a
  new me.up().down() cycle.




More information about the pve-devel mailing list