[pve-devel] [RFC PATCH manager] ui: ACMEAccountCreate: improve layout of account dialog
Dominik Csapak
d.csapak at proxmox.com
Thu May 14 14:26:55 CEST 2020
by increasing the space for the link, and using a boxLabel instead
of fieldLabel, which has better spacing for longer text
also move the e-mail before the directory to have all textboxes together
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
not really sure if it looks good now, but the current layout
is rather ugly, so sending it as rfc
www/manager6/node/ACME.js | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js
index fd33333b..6a2730cb 100644
--- a/www/manager6/node/ACME.js
+++ b/www/manager6/node/ACME.js
@@ -2,7 +2,7 @@ Ext.define('PVE.node.ACMEAccountCreate', {
extend: 'Proxmox.window.Edit',
mixins: ['Proxmox.Mixin.CBind'],
- width: 400,
+ width: 450,
title: gettext('Register Account'),
isCreate: true,
method: 'POST',
@@ -21,6 +21,13 @@ Ext.define('PVE.node.ACMEAccountCreate', {
allowBlank: (get) => !get('defaultExists'),
},
},
+ {
+ xtype: 'textfield',
+ name: 'contact',
+ vtype: 'email',
+ allowBlank: false,
+ fieldLabel: gettext('E-Mail')
+ },
{
xtype: 'proxmoxComboGrid',
name: 'directory',
@@ -90,7 +97,6 @@ Ext.define('PVE.node.ACMEAccountCreate', {
{
xtype: 'displayfield',
itemId: 'tos_url_display',
- fieldLabel: gettext('Terms of Service'),
renderer: PVE.Utils.render_optional_url,
name: 'tos_url_display'
},
@@ -102,7 +108,7 @@ Ext.define('PVE.node.ACMEAccountCreate', {
{
xtype: 'proxmoxcheckbox',
itemId: 'tos_checkbox',
- fieldLabel: gettext('Accept TOS'),
+ boxLabel: gettext('Accept TOS'),
submitValue: false,
validateValue: function(value) {
if (value && this.checked) {
@@ -111,13 +117,6 @@ Ext.define('PVE.node.ACMEAccountCreate', {
return false;
}
},
- {
- xtype: 'textfield',
- name: 'contact',
- vtype: 'email',
- allowBlank: false,
- fieldLabel: gettext('E-Mail')
- }
]
});
--
2.20.1
More information about the pve-devel
mailing list