[pve-devel] applied: [PATCH manager] ACME: fix fallback to implicit standalone plugin

[Thomas Lamprecht]

On 5/7/20 10:01 AM, Fabian Grünbichler wrote:
> we need to parse the config even if it does not exist - it will return
> the 'standalone' entry that's needed to be backwards compatible with
> existing setups.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> Note: there is an issue when attempting to WRITE the config if
> /etc/pve/priv/acme does not exist, but that shouldn't be a problem for
> existing setups ;)
> 
>  PVE/API2/ACMEPlugin.pm | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/PVE/API2/ACMEPlugin.pm b/PVE/API2/ACMEPlugin.pm
> index 71f53a35..84553011 100644
> --- a/PVE/API2/ACMEPlugin.pm
> +++ b/PVE/API2/ACMEPlugin.pm
> @@ -245,9 +245,7 @@ __PACKAGE__->register_method({
>  });
>  
>  sub load_config {
> -    my $cfg = {};
> -    $cfg = cfs_read_file($plugin_config_file) if -e "/etc/pve/$plugin_config_file";
> -    return $cfg;
> +    return cfs_read_file($plugin_config_file);
>  }
>  
>  1;
> 

applied, thanks, added a comment as followup though, as I could imagine
me or someone else doing this again in the future ;)