[pve-devel] [PATCH i18n] Add comment about make update

Stefan Reiter s.reiter at proxmox.com
Thu Aug 29 10:39:03 CEST 2019


On 8/29/19 10:06 AM, Dominic Jäger wrote:
> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
> ---
> I did not know that we have to run 'make update' when adding a new
> language to i18n and have overseen a lot of errors as a consequence [0].
> We might want to give (new) developers a hint at some place so that something
> like this does not happen anymore. The patch is a suggestion for this.

Maybe some kind of developer README would be useful in general? Having 
never looked at the i18n repo before there's multiple confusing things 
IMO (e.g. how do the compiled lang files from the built .deb get loaded? 
What does the 'update' target do to make it so important?).

> 
> [0] https://pve.proxmox.com/pipermail/pve-devel/2019-August/038665.html
> 
>   Makefile | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 442081f..4fe2cbf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -30,6 +30,7 @@ $(DEB1): | submodule
>   submodule:
>   	test -f "pmg-gui/Makefile" || git submodule update --init
>   
> +# run 'make update' before 'make install' if any .po file has been updated

Either way, I'm not sure a single comment in the Makefile is going to 
help that much - maybe at least put it somewhere at the top?

>   .PHONY: install
>   install: ${PMG_LANG_FILES} ${PVE_LANG_FILES}
>   	install -d ${PMGLOCALEDIR}
> 



More information about the pve-devel mailing list