[pve-devel] [PATCH i18n] Add comment about make update

Dominic Jäger d.jaeger at proxmox.com
Thu Aug 29 10:06:07 CEST 2019


Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
---
I did not know that we have to run 'make update' when adding a new
language to i18n and have overseen a lot of errors as a consequence [0].
We might want to give (new) developers a hint at some place so that something
like this does not happen anymore. The patch is a suggestion for this.

[0] https://pve.proxmox.com/pipermail/pve-devel/2019-August/038665.html

 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 442081f..4fe2cbf 100644
--- a/Makefile
+++ b/Makefile
@@ -30,6 +30,7 @@ $(DEB1): | submodule
 submodule:
 	test -f "pmg-gui/Makefile" || git submodule update --init
 
+# run 'make update' before 'make install' if any .po file has been updated
 .PHONY: install
 install: ${PMG_LANG_FILES} ${PVE_LANG_FILES}
 	install -d ${PMGLOCALEDIR}
-- 
2.20.1



More information about the pve-devel mailing list