[pve-devel] [PATCH i18n] Add comment about make update

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Aug 29 13:30:39 CEST 2019


On 29.08.19 10:39, Stefan Reiter wrote:
> On 8/29/19 10:06 AM, Dominic Jäger wrote:
>> Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
>> ---
>> I did not know that we have to run 'make update' when adding a new
>> language to i18n and have overseen a lot of errors as a consequence [0].
>> We might want to give (new) developers a hint at some place so that something
>> like this does not happen anymore. The patch is a suggestion for this.
> 
> Maybe some kind of developer README would be useful in general? Having never looked at the i18n repo before there's multiple confusing things IMO (e.g. how do the compiled lang files from the built .deb get loaded? What does the 'update' target do to make it so important?).

Just read the makefile? It isn't that long..

I'd rather see cleanup patches for build systems if something is really
unclear, even after trying to understand it, and can be improved - like
Fabian, I, and others did in the last years which improved the build situation
quite a bit, IMO..

And if, I'd add a small local README a general one is easily missed - both
by readers and potential updaters.

Also, there's already:
https://pve.proxmox.com/wiki/Developer_Documentation
https://git.proxmox.com/?p=pve-common.git;a=blob;f=README.dev;h=09631c09016c3b5954a8b23c6a262e29d85ebfd5;hb=HEAD

Which can be improved, if one wants.

> 
>>
>> [0] https://pve.proxmox.com/pipermail/pve-devel/2019-August/038665.html
>>
>>   Makefile | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 442081f..4fe2cbf 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -30,6 +30,7 @@ $(DEB1): | submodule
>>   submodule:
>>       test -f "pmg-gui/Makefile" || git submodule update --init
>>   +# run 'make update' before 'make install' if any .po file has been updated
> 
> Either way, I'm not sure a single comment in the Makefile is going to help that much - maybe at least put it somewhere at the top?

it's also wrong.. make update is not needed to be run before every make install,
else it would be a dependency of the "install" target..

It does what it says, it depends on "update_pot" and  "messages.pot", where
one updates all submodule to their upstreams current master, and pulls out
all gettext('') strings, concatenates them together and loops over all languages
to update and merge them so that we only have the unique and still relevant ones.

Dominic, the "make update" was really not required for your patch to be tested,
it is just something I do occasionally to pull in new gettext uses from our JS
projects, but it is not necessary for the translation to be installed and working.

> 
>>   .PHONY: install
>>   install: ${PMG_LANG_FILES} ${PVE_LANG_FILES}
>>       install -d ${PMGLOCALEDIR}
>>




More information about the pve-devel mailing list