[pve-devel] [PATCH firewall 1/2] Fix #1971: display firewall rule properties

[Rhonda D'Vine]

   Hi.

On 11/12/18 12:49 PM, Dominik Csapak wrote:
> On 11/12/18 12:27 PM, Rhonda D'Vine wrote:
>> ---
>>   src/PVE/API2/Firewall/Rules.pm | 48
>> +++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 47 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/API2/Firewall/Rules.pm
>> b/src/PVE/API2/Firewall/Rules.pm
>> index 1aa6d27..52a0935 100644
>> --- a/src/PVE/API2/Firewall/Rules.pm
>> +++ b/src/PVE/API2/Firewall/Rules.pm
>> @@ -122,9 +122,55 @@ sub register_get_rule {
>>       returns => {
>>           type => "object",
>>           properties => {
>> +        action => {
>> +            type => 'string',
>> +        },
>> +        comment => {
>> +            type => 'string',
>> +            optional => 1,
>> +        },
>> +        dest => {
>> +            type => 'string',
>> +            optional => 1,
>> +        },
>> +        dport => {
>> +            type => 'string',
>> +            optional => 1,
>> +        },
>> +        enable => {
>> +            type => 'intager',
>
> should probably be 'integer' ?

 Good catch - no clue how that slipped in. And what confuses me even
more that it doesn't seem to make a difference in the code because
that's what I have on my system and tested with.  *puzzled*

 v2 will come shortly.
Rhonda

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20181112/3c16116c/attachment.sig>