[pve-devel] [PATCH firewall 1/2] Fix #1971: display firewall rule properties

[Dominik Csapak]

On 11/12/18 12:27 PM, Rhonda D'Vine wrote:
> ---
>   src/PVE/API2/Firewall/Rules.pm | 48 +++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/API2/Firewall/Rules.pm b/src/PVE/API2/Firewall/Rules.pm
> index 1aa6d27..52a0935 100644
> --- a/src/PVE/API2/Firewall/Rules.pm
> +++ b/src/PVE/API2/Firewall/Rules.pm
> @@ -122,9 +122,55 @@ sub register_get_rule {
>   	returns => {
>   	    type => "object",
>   	    properties => {
> +		action => {
> +		    type => 'string',
> +		},
> +		comment => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		dest => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		dport => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		enable => {
> +		    type => 'intager',

should probably be 'integer' ?
> +		    optional => 1,
> +		},
> +		iface => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		ipversion => {
> +		    type => 'intager',
> +		    optional => 1,
> +		},
> +		macro => {
> +		    type => 'intager',
> +		    optional => 1,
> +		},
>   		pos => {
>   		    type => 'integer',
> -		}
> +		},
> +		proto => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		source => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		sport => {
> +		    type => 'string',
> +		    optional => 1,
> +		},
> +		type => {
> +		    type => 'string',
> +		},
>   	    },
>   	},
>   	code => sub {
>