[pve-devel] [PATCH ha-manager 2/3] fix #1378: allow to specify a service shutdown policy

[Fabian Grünbichler]

On Wed, Dec 19, 2018 at 01:21:53PM +0100, Thomas Lamprecht wrote:
> On 12/19/18 1:10 PM, Fabian Grünbichler wrote:
> > On Wed, Dec 19, 2018 at 11:39:40AM +0100, Thomas Lamprecht wrote:
> >> Allow an admin to set a datacenter wide HA policy which can change
> >> the way we handle services on a node shutdown.
> >>
> >> There's:
> >>
> >> * freeze: always freeze servivces, independent of the shutdown type
> >>   (reboot, poweroff)
> >> * failover: never freeze services, this means that a service will get
> >>   recovered to another node if possible and if the current node does
> >>   not comes back up in the grace period of 1 minute.
> > 
> > s/comes/come
> > 
> > why 1 minute here, and 2 minutes in the other patch? ;)
> 
> because i wrote this latter and actually checked here ;)
> 
> 1 minmute is the grace period where we mark a node as "fencing" required
> (see HA::NodeStatus is_node_delayed_offline), but we can only move them
> after 2 minutes.
> 
> So the will always be moved if the node is away for more than 60 seconds
> but only after 2 minutes, where it's lock expires.

did you miss the other comments (sorry for not pointing them out
explicitly)?

(the code is unchanged in v2)