[pve-devel] [PATCH cluster 2/2] add explaining comment for observed files

[Thomas Lamprecht]

On 12/19/18 11:24 AM, Dominik Csapak wrote:
> Without knowing that those are also defined elsewhere, the code can be
> easily confusing.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  data/PVE/Cluster.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm
> index f96de2f..ce4ae7c 100644
> --- a/data/PVE/Cluster.pm
> +++ b/data/PVE/Cluster.pm
> @@ -67,6 +67,9 @@ my $rootsshauthkeys = "/root/.ssh/authorized_keys";
>  my $rootsshauthkeysbackup = "${rootsshauthkeys}.org";
>  my $rootsshconfig = "/root/.ssh/config";
>  
> +# also defined in status.c

Hmm maybe:

must be in sync with the list from pmxcfs' status.c

to narrow which status.c and that they have a direct relation ship a bit clearer.

> +# this is necessary to be sure that we have a version of that file
> +# when using read/write, so that we can update the cache accordingly

maybe something like:

observed files are the one we get directly through IPCC, they are cached
by using a computed version and can be used by the cfs_*_file methods

This could be sent independent of your series, not directly related,
neither higher level nor diff context wise.

>  my $observed = {
>      'vzdump.cron' => 1,
>      'storage.cfg' => 1,
>