[pve-devel] [PATCH installer 2/2] implemented acknowledgement screen

Mon Dec 10 14:04:24 CET 2018

On 12/10/18 12:36 PM, Oguz Bektas wrote:
> this implements an acknowledgement screen as the last
> install step, which shows the user what they chose
> during the installation.
> 
> the html files have been modified according to the
> new installation steps as well.
> 

looks OK in general, I'd propose the following to make the formatting a bit
nicer and fitting to the rest of the installer/Proxmox VE theme:

----8<----
Author: Thomas Lamprecht <t.lamprecht at proxmox.com>
Date:   Mon Dec 10 12:50:06 2018 +0100

    improve summary screen styling

    use a more Proxmox VE like styling, differ background color of
    alternating rows slightly, fix missing tbody opening tag and try to
    match table column width  a bit better.

    Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>

diff --git a/html-common/ack_template.htm b/html-common/ack_template.htm
index af7f20a..6236ed1 100644
--- a/html-common/ack_template.htm
+++ b/html-common/ack_template.htm
@@ -2,11 +2,25 @@
 <html>
 <head>
 <link rel="stylesheet" type="text/css" href="pve-installer.css">
+<style type="text/css">
+    #summary td, tr {
+        padding: 3px;
+    }
+    #summary tr:nth-child(even){ background-color: #f2f2f2; }
+    #summary tr:hover { background-color: #ddd; }
+    #summary th {
+        padding-top: 5px;
+        padding-bottom: 5px;
+        padding-left: 5px;
+        text-align: left;
+        background-color: #e57000;
+        color: white;
+    }
+</style>
 </head>
 <body>
 <center>
-<table border="0" width="800">
-<tr><td> </td></tr>
+<table border="0" width="800" style="margin-top: 10pt;">
 <tr>
   <td colspan="4" align="center" width="800">
     <b class="htext">Summary</b>
@@ -26,10 +40,10 @@
     </tbody></table>
 </tr>

-<table border="0" width="800">
-
+<table id="summary" border="0" width="800">
+<tbody>
 <tr>
-    <th>Option</th>
+    <th width="25%">Option</th>
     <th>Value</th>
 </tr>

@@ -37,7 +51,6 @@
     <td>Disk:</td>
     <td>__target_hd__</td>
 </tr>
-
 <tr>
     <td>Country:</td>
     <td>__country__</td>


