[pve-devel] applied: [PATCH manager] Fix #2019: CephFS storage misses Max Backups

[Thomas Lamprecht]

On 12/7/18 9:02 AM, Alwin Antreich wrote:
> Signed-off-by: Alwin Antreich <a.antreich at proxmox.com>
> ---
>  www/manager6/storage/CephFSEdit.js | 13 ++++++++++++-
>  www/manager6/storage/RBDEdit.js    |  2 +-
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/storage/CephFSEdit.js b/www/manager6/storage/CephFSEdit.js
> index 0580e8fc..fff68b1d 100644
> --- a/www/manager6/storage/CephFSEdit.js
> +++ b/www/manager6/storage/CephFSEdit.js
> @@ -69,9 +69,20 @@ Ext.define('PVE.storage.CephFSInputPanel', {
>  		cts: ['backup', 'iso', 'vztmpl'],
>  		fieldLabel: gettext('Content'),
>  		name: 'content',
> -		value: ['backup'],
> +		value: 'backup',
>  		multiSelect: true,
>  		allowBlank: false
> +	    },
> +	    {
> +		xtype: 'proxmoxintegerfield',
> +		fieldLabel: gettext('Max Backups'),
> +		disabled: true,

applied, but removed the above line as a fixup, as this is not valid for CephFS.
You probably copied it from a storage plugin which has 'backup' not included in the
default content type selection, so there the initial state has to be disabled.
But with CephFS this isn't the case, there backup is the default (allowed) content
type and thus this need to be enabled from the start...


> +		name: 'maxfiles',
> +		reference: 'maxfiles',
> +		minValue: 0,
> +		maxValue: 365,
> +		value: me.isCreate ? '1' : undefined,
> +		allowBlank: false
>  	    }
>  	];
>  
> diff --git a/www/manager6/storage/RBDEdit.js b/www/manager6/storage/RBDEdit.js
> index c38759df..4ecd98e4 100644
> --- a/www/manager6/storage/RBDEdit.js
> +++ b/www/manager6/storage/RBDEdit.js
> @@ -10,7 +10,7 @@ Ext.define('PVE.storage.Ceph.Model', {
>  });
>  
>  Ext.define('PVE.storage.Ceph.Controller', {
> -    extend: 'Ext.app.ViewController',
> +    extend: 'PVE.controller.StorageEdit',
>      alias: 'controller.cephstorage',
>  
>      control: {
>