[pve-devel] [RFC PATCH] fix #1471: change keyboard default to undef

Dominik Csapak d.csapak at proxmox.com
Tue Nov 7 11:09:30 CET 2017


this means that we do not include the '-k' parameter anymore by default
(which is deprecated by qemu)

with this, noVNC and spice always respect the guest keyboard
configuration and altgr keys work without problems

tested:
ubuntu with english intl and german with novnc and spice
windows 10 with english intl and german with novnc and spice
live migration

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 PVE/QemuServer.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 896089f..ab26ebb 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -243,9 +243,10 @@ my $confdesc = {
     keyboard => {
 	optional => 1,
 	type => 'string',
-	description => "Keybord layout for vnc server. Default is read from the '/etc/pve/datacenter.conf' configuration file.",
+	description => "Keybord layout for vnc server. Default is read from the '/etc/pve/datacenter.conf' configuration file.".
+		       "It should not be necessary to set it.",
 	enum => PVE::Tools::kvmkeymaplist(),
-	default => 'en-us',
+	default => undef,
     },
     name => {
 	optional => 1,
-- 
2.11.0





More information about the pve-devel mailing list