[pve-devel] applied: [RFC PATCH] fix #1471: change keyboard default to undef

[Wolfgang Bumiller]

Applied. Yay, finally the us(altgr-intl) layout seems to fully work over
vnc in the browser.


On Tue, Nov 07, 2017 at 11:09:30AM +0100, Dominik Csapak wrote:
> this means that we do not include the '-k' parameter anymore by default
> (which is deprecated by qemu)
> 
> with this, noVNC and spice always respect the guest keyboard
> configuration and altgr keys work without problems
> 
> tested:
> ubuntu with english intl and german with novnc and spice
> windows 10 with english intl and german with novnc and spice
> live migration
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/QemuServer.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 896089f..ab26ebb 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -243,9 +243,10 @@ my $confdesc = {
>      keyboard => {
>  	optional => 1,
>  	type => 'string',
> -	description => "Keybord layout for vnc server. Default is read from the '/etc/pve/datacenter.conf' configuration file.",
> +	description => "Keybord layout for vnc server. Default is read from the '/etc/pve/datacenter.conf' configuration file.".
> +		       "It should not be necessary to set it.",
>  	enum => PVE::Tools::kvmkeymaplist(),
> -	default => 'en-us',
> +	default => undef,
>      },
>      name => {
>  	optional => 1,
> -- 
> 2.11.0