[pve-devel] partially applied: [PATCH manager v2 0/3] Fix #1523: Disable 'Max Backup' entry when not applicable

Wolfgang Bumiller w.bumiller at proxmox.com
Tue Nov 7 10:18:03 CET 2017


Applied patches 1 & 2.

On Tue, Oct 31, 2017 at 03:52:11PM +0100, Emmanuel Kasper wrote:
> Since the Max Backups field is now depending of having the Content Type
> set to 'backup', it makes sense to group these two fields.

I'm not fully convinced. We do have existing cases where the left fields
enable/disable fields on the right (eg. quota when adding a mount point
to a container).
Waiting with this patch for more convincing feedback.

On Tue, Oct 31, 2017 at 03:52:08PM +0100, Emmanuel Kasper wrote:
> changes since V1:
>  * remove wrong whitespace in DirEdit.js
>  * reset Max Backups value before disabling it in StorageEdit.js
> 
> Emmanuel Kasper (3):
>   Add Storage Controller class
>   Fix #1523: Display the Max Backups field only if relevant
>   Move Max Backups field below the Content Type Selector




More information about the pve-devel mailing list