[pve-devel] [PATCH v5 0/3] RFC: cloud-init update

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Jun 26 12:36:52 CEST 2015


We just talked this over a bit again.

If we keep going with this approach we could actually remove the
cloudinit config parameter and, similar to what Alexandre did in the
first patches, have an `ideX: cloudinit,storage=STOREID` parameter
enable cloudinit (but have it fix in the config rather than added after
doing `cloudinit: 1`).
For the UI enabling and disabling cloudinit would then be
adding/removing a cloudinit device. It would then also not have to be
hardcoded to ide3 but be configurable to any block device like when
adding a hard disk.

We'd then still need a parameter for templates. (Either a new one like
`cloudinit-template: xyz` or if we plan on adding more cloud-init
parameters we could keep `cloudinit: variouts,comma=separated,args`.

Another TODO before I forget about it again: physical cdrom drives
probably don't need `media=cdrom` in the code. should check that.

On Fri, Jun 26, 2015 at 12:06:31PM +0200, Wolfgang Bumiller wrote:
> Changes since [PATCH v4]:
> 
> Instead of generating a separate ISO image file we now generate the
> ISO into a qcow2 device which is storage-managed.
> This does not only mean we don't need to rsync the file for
> live-migrations, but we can also use the live-snapshot feature out of
> the box.
> 
> It also allowed me to remove the code to generate the commandline
> parameters by simply making foreach_drive include the cloud-init drive
> (if it exists).
> In order to do that I had to add a $vmid parameter to it. Since it
> already takes the VM's config as parameter this seemed like a sane
> thing to do. I grepped the rest of the repositories for code affected
> by this change. It seemed to be all isolated in qemu-server.
> 
> Please test and comment.
> 
> Alexandre Derumier (1):
>   implement cloudinit v2
> 
> Wolfgang Bumiller (2):
>   cloud-init changes
>   cloudinit: use qcow2 for future snapshot support
> 
>  PVE/API2/Qemu.pm         |  16 +--
>  PVE/QemuMigrate.pm       |   8 +-
>  PVE/QemuServer.pm        | 364 +++++++++++++++++++++++++++++++++++++++++++----
>  PVE/VZDump/QemuServer.pm |   2 +-
>  control.in               |   2 +-
>  5 files changed, 353 insertions(+), 39 deletions(-)
> 
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at pve.proxmox.com
> http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 



More information about the pve-devel mailing list